Skip to content

AsciiEffect: avoid useless split operations #30667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mugen87 merged 1 commit into from
Mar 7, 2025
Merged

AsciiEffect: avoid useless split operations #30667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions examples/jsm/effects/AsciiEffect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,6 @@ class AsciiEffect {
}


const aDefaultCharList = ( ' .,:;i1tfLCG08@' ).split( '' );
const aDefaultColorCharList = ( ' CGO08@' ).split( '' );
const strFont = 'courier new, monospace';

const oCanvasImg = renderer.domElement;
Expand All @@ -138,9 +136,19 @@ class AsciiEffect {

}

let aCharList = ( bColor ? aDefaultColorCharList : aDefaultCharList );
let aCharList;
if ( charSet ) {

aCharList = ( charSet ).split( '' );

} else {

const aDefaultCharList = ( ' .,:;i1tfLCG08@' ).split( '' );
const aDefaultColorCharList = ( ' CGO08@' ).split( '' );
aCharList = ( bColor ? aDefaultColorCharList : aDefaultCharList );

}

if ( charSet ) aCharList = charSet;

// Setup dom

Expand Down