Skip to content

Conversation

@cmhhelgeson
Copy link
Contributor

@cmhhelgeson cmhhelgeson commented Feb 24, 2025

Related issues: ##22217, #22220

Description

Assign currentRenderState to renderStateStack.pop() to more closely align renderer.compile()'s behavior with its pre r131.1 behavior.

@github-actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.65
78.39
336.64
78.39
-5 B
+0 B
WebGPU 522.53
145.06
522.53
145.06
+0 B
+0 B
WebGPU Nodes 522
144.96
522
144.96
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.7
112.26
465.69
112.26
-5 B
+0 B
WebGPU 593
160.69
593
160.69
+0 B
+0 B
WebGPU Nodes 548.13
150.12
548.13
150.12
+0 B
+0 B

@Mugen87 Mugen87 added this to the r174 milestone Feb 25, 2025
@Mugen87 Mugen87 merged commit cb70102 into mrdoob:dev Feb 25, 2025
12 checks passed
@cmhhelgeson cmhhelgeson deleted the cmh/adjust_compile branch February 25, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants