-
-
Notifications
You must be signed in to change notification settings - Fork 36k
TSL: Introduce varying.setInterpolation()
#30582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
I decided to just use @isaac-mason's basic sample for now, leaving the creation of a more dynamic sample for a later time. If possible, please include Isaac as a contributor to this PR. |
It would be interesting to have the variables in the constants. For example: |
varying.setInterpolation()
@cmhhelgeson It seems the options
Is that a regression? |
No this behavior is incorrect. The @interpolate tag should only be (flat, first), not (flat, flat first). This would be an error in how the code is being constructed. |
I think this might actually just be an issue with the sample, I'll look into it. |
Related issue: #30576
Description
Modifies VaryingNode, allowing the user to directly define interpolation and sampling types for a varying node. In cases where no interpolation is defined, the default optimizations/behavior stays in place.