WebGPURenderer: Honor polygonOffset with WebGPU backend.
#30496
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #30494.
Description
The PR adds
Material.polygonOffsetsupport to the WebGPU backend. The WebGL backend already supports it.Note: The semantics of
polygonOffsetin WebGPU are different than in WebGL. When understanding the specs correctly,polygonOffsetUnitsshould be mapped todepthBiasandpolygonOffsetFactortodepthBiasSlopeScale. It seems that makes the most sense.WebGPU: https://www.w3.org/TR/webgpu/#dom-gpudepthstencilstate-depthbias
WebGL: https://developer.mozilla.org/en-US/docs/Web/API/WebGLRenderingContext/polygonOffset
@AndrewChan2022 Would this work for you?