Skip to content

WebGLBackend: Fix context parameter. #30413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mugen87 merged 2 commits into from
Jan 28, 2025
Merged

WebGLBackend: Fix context parameter. #30413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb62516
WebGLBackend: Fix context parameter.
Mugen87 Jan 28, 2025
8b8bebd
WebGLBackend: Disable depth buffer of canvas.
Mugen87 Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 10 additions & 12 deletions src/renderers/common/XRManager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,8 +589,6 @@ class XRManager extends EventDispatcher {

//

const attributes = gl.getContextAttributes();

if ( this._useLayers === true ) {

// default path using XRWebGLBinding/XRProjectionLayer
Expand All @@ -599,11 +597,11 @@ class XRManager extends EventDispatcher {
let depthType = null;
let glDepthFormat = null;

if ( attributes.depth ) {
if ( renderer.depth ) {

glDepthFormat = attributes.stencil ? gl.DEPTH24_STENCIL8 : gl.DEPTH_COMPONENT24;
depthFormat = attributes.stencil ? DepthStencilFormat : DepthFormat;
depthType = attributes.stencil ? UnsignedInt248Type : UnsignedIntType;
glDepthFormat = renderer.stencil ? gl.DEPTH24_STENCIL8 : gl.DEPTH_COMPONENT24;
depthFormat = renderer.stencil ? DepthStencilFormat : DepthFormat;
depthType = renderer.stencil ? UnsignedInt248Type : UnsignedIntType;

}

Expand Down Expand Up @@ -632,8 +630,8 @@ class XRManager extends EventDispatcher {
type: UnsignedByteType,
colorSpace: renderer.outputColorSpace,
depthTexture: new DepthTexture( glProjLayer.textureWidth, glProjLayer.textureHeight, depthType, undefined, undefined, undefined, undefined, undefined, undefined, depthFormat ),
stencilBuffer: attributes.stencil,
samples: attributes.antialias ? 4 : 0
stencilBuffer: renderer.stencil,
samples: renderer.samples
} );

this._xrRenderTarget.hasExternalTextures = true;
Expand All @@ -643,10 +641,10 @@ class XRManager extends EventDispatcher {
// fallback to XRWebGLLayer

const layerInit = {
antialias: attributes.antialias,
antialias: renderer.samples > 0,
alpha: true,
depth: attributes.depth,
stencil: attributes.stencil,
depth: renderer.depth,
stencil: renderer.stencil,
framebufferScaleFactor: this.getFramebufferScaleFactor()
};

Expand All @@ -665,7 +663,7 @@ class XRManager extends EventDispatcher {
format: RGBAFormat,
type: UnsignedByteType,
colorSpace: renderer.outputColorSpace,
stencilBuffer: attributes.stencil
stencilBuffer: renderer.stencil
}
);

Expand Down
9 changes: 8 additions & 1 deletion src/renderers/webgl-fallback/WebGLBackend.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,14 @@ class WebGLBackend extends Backend {

const parameters = this.parameters;

const glContext = ( parameters.context !== undefined ) ? parameters.context : renderer.domElement.getContext( 'webgl2' );
const contextAttributes = {
antialias: false, // MSAA is applied via a custom renderbuffer
alpha: true, // always true for performance reasons
depth: false, // depth and stencil are set to false since the engine always renders into a framebuffer target first
stencil: false
};

const glContext = ( parameters.context !== undefined ) ? parameters.context : renderer.domElement.getContext( 'webgl2', contextAttributes );

function onContextLost( event ) {

Expand Down
Loading