Skip to content

Conversation

@Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jan 27, 2025

Fixed #30404.

Description

The PR makes sure src/renderers/common/Geometries.js reuses arrayNeedsUint32() from src/utils.js and does not rely on a copy.

@github-actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.27
78.29
336.27
78.29
+0 B
+0 B
WebGPU 512.43
142.35
512.38
142.34
-50 B
-10 B
WebGPU Nodes 511.9
142.25
511.85
142.24
-50 B
-9 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.25
112.13
465.25
112.13
+0 B
+0 B
WebGPU 586.38
159.04
586.31
159
-68 B
-33 B
WebGPU Nodes 541.76
148.6
541.7
148.55
-68 B
-48 B

@Mugen87 Mugen87 merged commit cb91f1a into mrdoob:dev Jan 27, 2025
12 checks passed
@Mugen87 Mugen87 added this to the r173 milestone Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

three.webgpu.js contains identically-named items "arrayNeedsUint32", "Uniform", and "UniformsGroup" that are also found in three.core.js

1 participant