Skip to content

Improve ArcballControls internal documentation #30372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Mugen87 merged 1 commit into from
Jan 21, 2025
Merged

Improve ArcballControls internal documentation #30372

Mugen87 merged 1 commit into from
Jan 21, 2025

Conversation

@s-rigaud
Copy link
Contributor

@s-rigaud s-rigaud commented Jan 21, 2025 •
edited
Loading

Description

  • Rename EPS to match other controls
  • Move documentation closer to the constructor to get typing on class attributes and constructor params
  • Minor type imporvements

@Mugen87 Mugen87 added this to the r173 milestone Jan 21, 2025
@Mugen87 Mugen87 merged commit a7ed16e into mrdoob:dev Jan 21, 2025
11 checks passed
@s-rigaud s-rigaud deleted the improve-arcball-jsdoc branch January 22, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r173

Development

Successfully merging this pull request may close these issues.

2 participants

@s-rigaud @Mugen87