Skip to content

XRManager: Add layers support. #30365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2025
Merged

XRManager: Add layers support. #30365

merged 1 commit into from
Jan 20, 2025
+214 −288

Conversation

@Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jan 20, 2025 •
edited
Loading

Related issue: #28968

Description

This PR adds support for the WebXR Layers API to XRManager.

@github-actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.25
78.28		 336.25
78.28		 +0 B
+0 B
WebGPU 503.66
139.88		 505.42
140.35		 +1.76 kB
+472 B
WebGPU Nodes 503.13
139.77		 504.89
140.25		 +1.76 kB
+484 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.25
112.13		 465.25
112.13		 +0 B
+0 B
WebGPU 577.44
156.5		 579.19
156.98		 +1.76 kB
+476 B
WebGPU Nodes 532.82
146.06		 534.58
146.53		 +1.76 kB
+465 B

@Mugen87 Mugen87 added this to the r173 milestone Jan 20, 2025
@Mugen87 Mugen87 merged commit 35a466d into mrdoob:dev Jan 20, 2025
12 checks passed
sunag
sunag reviewed Jan 20, 2025
View reviewed changes
@Mugen87 Mugen87 mentioned this pull request Jan 21, 2025
Merged
This was referenced Jan 27, 2025
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sunag sunag sunag left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r173

Development

Successfully merging this pull request may close these issues.

2 participants

@Mugen87 @sunag