Skip to content

Conversation

@Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jan 7, 2025

Fixed #29825.

Description

Makes sure apps can use more than one renderer/post processing setup.

Also adds PostProcessing.dispose().

@Mugen87 Mugen87 added this to the r173 milestone Jan 7, 2025
@github-actions
Copy link

github-actions bot commented Jan 7, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.49
79.09
339.49
79.09
+0 B
+0 B
WebGPU 489.81
135.9
489.92
135.91
+101 B
+11 B
WebGPU Nodes 489.28
135.78
489.38
135.79
+101 B
+9 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.35
112.14
465.35
112.14
+0 B
+0 B
WebGPU 559.29
151.38
559.29
151.38
+0 B
+0 B
WebGPU Nodes 515.37
141.16
515.37
141.16
+0 B
+0 B

@Mugen87 Mugen87 merged commit eb84f92 into mrdoob:dev Jan 7, 2025
12 checks passed
@cmhhelgeson
Copy link
Contributor

So glad this is in now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WebGPURenderer: Multiple renderer setup with FX produces warnings.

2 participants