TSL: Vertex shader revision #30108
Merged
TSL: Vertex shader revision #30108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
|
Maybe we can follow use WebGL's |
This was referenced Dec 15, 2024
0b5vr
added a commit
to pixiv/three-vrm
that referenced
this pull request
May 16, 2025
We can't use `positionView` in `setupPosition` because using `positionView` there will make it calculate the `positionView` earlier and it won't be calculated again after setting the `positionNode` It might be an unexpected bug on the Three.js side...? It caused by mrdoob/three.js#30108 I think
0b5vr
added a commit
to pixiv/three-vrm
that referenced
this pull request
May 21, 2025
We can't use `positionView` in `setupPosition` because using `positionView` there will make it calculate the `positionView` earlier and it won't be calculated again after setting the `positionNode` It might be an unexpected bug on the Three.js side...? It caused by mrdoob/three.js#30108 I think
0b5vr
added a commit
to pixiv/three-vrm
that referenced
this pull request
May 27, 2025
We can't use `positionView` in `setupPosition` because using `positionView` there will make it calculate the `positionView` earlier and it won't be calculated again after setting the `positionNode` It might be an unexpected bug on the Three.js side...? It caused by mrdoob/three.js#30108 I think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #29555 (comment), #29659 (comment)
Description
The PR fixes the
SpriteMaterialfog and brings some improvements related to MVP and Vertex.foginSpriteMaterialandSpriteNodeMaterialNodeMaterial:Add.setupPositionView()NodeMaterial:Add.setupVertex()modelViewProjectionis a const now instead of a function likemodelViewProjection()mediumpModelViewMatrixhighPrecisionModelNormalViewMatrix->highpModelNormalViewMatrixhighPrecisionModelViewMatrix->highpModelViewMatrix