Skip to content

Node: Document more modules. #30000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 30, 2024
Merged

Node: Document more modules. #30000

merged 7 commits into from
Nov 30, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Nov 30, 2024

Related issue: #29984

Description

More documentation for the node classes.

Copy link

github-actions bot commented Nov 30, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.14
78.99
339.14
78.99
+0 B
+0 B
WebGPU 484.69
134.48
484.63
134.49
-57 B
+13 B
WebGPU Nodes 484.15
134.38
484.1
134.4
-57 B
+12 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 464.61
111.98
464.61
111.98
+0 B
+0 B
WebGPU 553.43
149.79
553.37
149.8
-57 B
+10 B
WebGPU Nodes 509.31
139.5
509.25
139.51
-57 B
+10 B

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Nov 30, 2024

image

Nice milestone, btw^^.

@Mugen87 Mugen87 added this to the r172 milestone Nov 30, 2024
@Mugen87 Mugen87 merged commit f81793c into mrdoob:dev Nov 30, 2024
12 checks passed
@@ -2,6 +2,12 @@ import TempNode from '../core/TempNode.js';
import { addMethodChaining, nodeProxy } from '../tsl/TSLCore.js';
import { vectorComponents } from '../core/constants.js';

/**
* These node represents an assing operation. Meaning a node is assigned
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assing?!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants