ArcballControls: Add enableFocus.
#29871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
approved these changes
Nov 18, 2024
Mugen87
changed the title
enableFocus.
31 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I’m developing a 3D Point Cloud editor using Three.js, and I’m using ArcballControls because it’s the best fit for this project. While editing (especially when removing noise points at specific click locations), unwanted focus events often get triggered by double-tap actions, which hurts the user experience.
To improve this, I’ve modified ArcballControls to prevent double-tap (or double-click) actions from triggering focus when it’s not wanted. I’ve added a new enableFocus property that allows users to disable the focus action, helping to avoid interruptions during editing.
Here's a GIF showing how it works:
