CSSRenderer: Ensure removing CSS objects works within iFrames. #29663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
approved these changes
Oct 15, 2024
Mugen87
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #29660
Description
scene.remove(CSS2DObjectInstance)may not work correctly if the CSS2DRenderer is inside an iframe.Here is the demo of the problem:
https://jsfiddle.net/87f9azgn/
This PR is to fix it.
As I mentioned #29660 (comment) ,
The constructor of DOM element depends on its window.
Therefore
object.element instanceof Elementmay not work in an iframe.Elementis actuallywindow.Elementand not aiframeWindow.Element.