Skip to content

Examples: Fix webgpu_tsl_procedural_terrain warning #29574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 7, 2024
Merged

Examples: Fix webgpu_tsl_procedural_terrain warning #29574

merged 3 commits into from
Oct 7, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Oct 7, 2024 •
edited
Loading

Related issue: #29137

Description

Some additional revisions of the use of normals.

@sunag sunag added this to the r170 milestone Oct 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 688.12
170.5		 688.12
170.5		 +0 B
+0 B
WebGPU 807.93
217.62		 807.99
217.64		 +54 B
+19 B
WebGPU Nodes 807.44
217.48		 807.5
217.5		 +54 B
+19 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 462.84
111.78		 462.84
111.78		 +0 B
+0 B
WebGPU 535.68
144.56		 535.73
144.57		 +54 B
+16 B
WebGPU Nodes 491.79
134.31		 491.85
134.32		 +61 B
+7 B

@sunag sunag marked this pull request as ready for review October 7, 2024 05:48
@sunag sunag merged commit 2344891 into mrdoob:dev Oct 7, 2024
12 checks passed
@sunag sunag deleted the dev-fix-normal-usage branch October 7, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r170
Development

Successfully merging this pull request may close these issues.
1 participant
@sunag