Skip to content

TSL: Deprecated .temp() #29516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 28, 2024
Merged

TSL: Deprecated .temp() #29516

merged 5 commits into from
Sep 28, 2024

Conversation

@sunag
Copy link
Collaborator

@sunag sunag commented Sep 28, 2024

Related issue: #29495 (comment)

Description

Deprecated .temp()

@sunag sunag added this to the r170 milestone Sep 28, 2024
@github-actions
Copy link

github-actions bot commented Sep 28, 2024 •
edited
Loading

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 687.15
170.18		 687.15
170.18		 +0 B
+0 B
WebGPU 805.73
216.91		 805.82
216.97		 +87 B
+50 B
WebGPU Nodes 805.24
216.78		 805.33
216.83		 +87 B
+51 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 462.85
111.79		 462.85
111.79		 +0 B
+0 B
WebGPU 535.52
144.5		 535.59
144.55		 +77 B
+49 B
WebGPU Nodes 491.67
134.26		 491.75
134.31		 +77 B
+44 B

@sunag sunag marked this pull request as ready for review September 28, 2024 01:34
@sunag sunag merged commit 9355893 into mrdoob:dev Sep 28, 2024
11 checks passed
@sunag sunag deleted the dev-tovar branch September 28, 2024 01:35
This was referenced Oct 24, 2024
Merged
Closed
0b5vr added a commit to pixiv/three-vrm that referenced this pull request Nov 21, 2024
@0b5vr
fix: NodeMaterials, .temp() -> .toVar()
c85fa6e 
`.temp()` is deprecated in r170
See: mrdoob/three.js#29516

examples are working even in r167
@0b5vr 0b5vr mentioned this pull request Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r170

Development

Successfully merging this pull request may close these issues.

1 participant

@sunag