WebGPURenderer: Introduce hash-based cache key #29479
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #29386, #29212 (comment)
Description
A numeric cache key brings a performance gain in the rendering cycle ( #29386 ) in addition to saving memory because it is just an integer instead of sometimes big strings.
As
RenderObjectshashes inherited the individuality ofRenderContext, the possibility of collision decreases, among other detail that can be improved in case of we encounter any collision issues.I was thinking about using the
getHashterminology but I had some conflicts with some existing functions.