CurveModifier: Add WebGPU version. #29453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 20, 2024 09:18
Mugen87
reviewed
Sep 21, 2024
Collaborator
I think I would leave out instancing support in the modifier until it is requested by a user. |
Mugen87
approved these changes
Sep 23, 2024
Mugen87
changed the title
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #29295
Port of non instanced curve modifier.
This example exposes a problem with BufferGeometry.setFromPoints() method. #29452
I have a version with instancing support which requires a method to override NodeMaterial() standard instance handling and provide access to instanceMatrix and instanceColor independently.