Skip to content

WebGPURenderer: GaussianBlurNode reduce overhead #27447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sunag merged 2 commits into from
Dec 27, 2023
Merged

WebGPURenderer: GaussianBlurNode reduce overhead #27447

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e62c6d
use two quadmeshes
Dec 26, 2023
8bf666a
add tip
sunag Dec 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions examples/jsm/nodes/display/GaussianBlurNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,11 @@ import { uniform } from '../core/UniformNode.js';
import { Vector2, RenderTarget } from 'three';
import QuadMesh from '../../objects/QuadMesh.js';

const quadMesh = new QuadMesh();
// WebGPU: The use of a single QuadMesh for both gaussian blur passes results in a single RenderObject with a SampledTexture binding that
// alternates between source textures and triggers creation of new BindGroups and BindGroupLayouts every frame.

const quadMesh1 = new QuadMesh();
const quadMesh2 = new QuadMesh();

class GaussianBlurNode extends TempNode {

Expand Down Expand Up @@ -54,7 +58,8 @@ class GaussianBlurNode extends TempNode {
const currentRenderTarget = renderer.getRenderTarget();
const currentTexture = textureNode.value;

quadMesh.material = this._material;
quadMesh1.material = this._material;
quadMesh2.material = this._material;

this.setSize( map.image.width, map.image.height );

Expand All @@ -64,7 +69,7 @@ class GaussianBlurNode extends TempNode {

this._passDirection.value.set( 1, 0 );

quadMesh.render( renderer );
quadMesh1.render( renderer );

// vertical

Expand All @@ -73,7 +78,7 @@ class GaussianBlurNode extends TempNode {

this._passDirection.value.set( 0, 1 );

quadMesh.render( renderer );
quadMesh2.render( renderer );

// restore

Expand Down