Skip to content

BatchedMesh: Fix getIndexCount, getVertexCount functions #27099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gkjohnson merged 2 commits into from
Nov 1, 2023
Merged

BatchedMesh: Fix getIndexCount, getVertexCount functions #27099

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3123d4a
BatchedMesh: Fix getVertexCount and getIndexCount functions
gkjohnson Nov 1, 2023
8b6addf
BatchedMesh: Fix index offset
gkjohnson Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions examples/jsm/objects/BatchedMesh.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,6 @@ class BatchedMesh extends Mesh {

this._geometryInitialized = false;
this._geometryCount = 0;
this._vertexCount = 0;
this._indexCount = 0;

// Local matrix per geometry by using data texture
// @TODO: Support uniform parameter per geometry
Expand Down Expand Up @@ -300,13 +298,34 @@ class BatchedMesh extends Mesh {

getVertexCount() {

return this._vertexCount;
const reservedRanges = this._reservedRanges;
if ( reservedRanges.length === 0 ) {

return 0;

} else {

const finalRange = reservedRanges[ reservedRanges.length - 1 ];
return finalRange.vertexStart + finalRange.vertexCount;

}

}

getIndexCount() {

return this._indexCount;
const reservedRanges = this._reservedRanges;
const geometry = this.geometry;
if ( geometry.getIndex() === null || reservedRanges.length === 0 ) {

return 0;

} else {

const finalRange = reservedRanges[ reservedRanges.length - 1 ];
return finalRange.indexStart + finalRange.indexCount;

}

}

Expand Down