Skip to content

Conversation

@sunag
Copy link
Collaborator

@sunag sunag commented Jul 24, 2023

Related issue: #25170

Description

The Lighting Model can now be extended and have internal parameters, thus making the system more organized. This concept follows the one implemented in the customization of lights and materials.

const lighingModel = new PhongLightingModel();

// force lambert
lighingModel.specular = false;
const lighingModel = new PhysicalLightingModel();

// force standard
lighingModel.clearcoat = false;
lighingModel.sheen = false;

@sunag sunag added this to the r155 milestone Jul 24, 2023
@sunag sunag marked this pull request as ready for review July 24, 2023 20:08
@sunag sunag mentioned this pull request Jul 25, 2023
4 tasks
@sunag sunag merged commit 93996d7 into mrdoob:dev Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant