fix: toCreasedNormals(): call toNonIndexed() only on non-indexed geometries #26379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpvhn
force-pushed
the
fix/nonindexed-tocreasenormals
branch
from
83e9861 to
40a0f74
Compare
… indexed geometries
kpvhn
force-pushed
the
fix/nonindexed-tocreasenormals
branch
from
40a0f74 to
ccbb6f3
Compare
… formatting & remove redundant info
kpvhn
force-pushed
the
fix/nonindexed-tocreasenormals
branch
from
a6baa77 to
1ea6198
Compare
LeviPesin
reviewed
Jul 6, 2023
gkjohnson
reviewed
Jul 16, 2023
gkjohnson
approved these changes
Jul 17, 2023
This was referenced Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #26378
Description
BufferGeometryUtils.toCreasedNormals()produces a warning byBufferGeometry.toNonIndexed()if the provided geometry is already non-indexed:It should not produce the warning.
This PR changes
BufferGeometryUtils.toCreasedNormals()to callBufferGeometry.toNonIndexed()only if the provided geometry is indexed.Otherwise, it will just use the original geometry, as has been the case before:
BufferGeometry.toNonIndexed()returnsthisif the geometry is non-indexed.