Examples: More usage of useLegacyLights=false.
#26267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 16, 2023
cstegel
added a commit
to cstegel/three.js
that referenced
this pull request
Jul 26, 2023
See: 1. mrdoob#26392 2. mrdoob#26267 The default behavior of light intensities was changed. Some examples had the light intensity values changed from 1 to 3 to preserve the old behavior. This is necessary after merging dev into this branch. The screenshots still visually look the same but I am committing them as well in case there were any subtle changes due to this change in lighting behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: -
Description
This PR makes sure more examples use
useLegacyLights=false.I've started with the examples which are easy to migrate meaning where minor adjustments to the lights restore the previous looks. I also set the flag in all examples using unlint materials so we know an example has been reviewed and is fine.