Skip to content

Conversation

@LeviPesin
Copy link
Contributor

Related issue: -

Description

Remove long-deprecated code.

@github-actions
Copy link

github-actions bot commented May 31, 2023

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
644.1 kB (159.5 kB) 640 kB (158.8 kB) -4.1 kB

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
434.1 kB (105.1 kB) 433.3 kB (105 kB) -811 B

@LeviPesin LeviPesin marked this pull request as ready for review May 31, 2023 16:06
@LeviPesin
Copy link
Contributor Author

LeviPesin commented May 31, 2023

Seems like webgl_geometry_csg breaks? 🤔 /ping @gkjohnson
Does it use any of the *BufferGeometry aliases?

@Mugen87
Copy link
Collaborator

Mugen87 commented Jun 2, 2023

If you open the browser console, the error becomes evident:

Uncaught SyntaxError: The requested module 'three' does not provide an export named 'SphereBufferGeometry'

PointsHelper needs an update: https://github.com/gkjohnson/three-bvh-csg/blob/70f80954e25a089d755afa6a79f9d47b60543eac/src/objects/PointsHelper.js#L14

@LeviPesin
Copy link
Contributor Author

I think this PR should work now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants