Examples: Clean up. #26135
Merged
Examples: Clean up. #26135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
commented
May 25, 2023
| minColor.set( this.map[ j ][ 1 ] ); | ||
| maxColor.set( this.map[ j + 1 ][ 1 ] ); | ||
| minColor.setHex( this.map[ j ][ 1 ], LinearSRGBColorSpace ); | ||
| maxColor.setHex( this.map[ j + 1 ][ 1 ], LinearSRGBColorSpace ); |
There was a problem hiding this comment.
The lerp should be done with sRGB colors so I use this approach to avoid a color space conversion when setting the hex values. I'm open for different approach since using LinearSRGBColorSpace is a bit confusing at first glance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: -
Description
MMDLoadernow always converts the sRGB material definitions to linear (which is not automatically done when usingColor.fromArray()).LUTis now also converted to sRGB.VRMLLoader.