Skip to content

Conversation

@zeux
Copy link
Contributor

@zeux zeux commented May 17, 2023

This is necessary to make glTF files that use KHR_materials_anisotropy together with KHR_texture_transform work properly.

Tested using gltfpack and updated model from glTF-Sample-Models that specifies the texture properly + some local fixes to the model:

image

This is necessary to make glTF files that use KHR_materials_anisotropy
together with KHR_texture_transform work properly.
@github-actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
642.7 kB (159.1 kB) 642.8 kB (159.1 kB) +147 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
432.5 kB (104.8 kB) 432.7 kB (104.8 kB) +146 B

@WestLangley
Copy link
Collaborator

Note: the model is currently under development.

See KhronosGroup/glTF-Sample-Models#366

@mrdoob
Copy link
Owner

mrdoob commented May 17, 2023

/ping @elalish

@elalish
Copy link
Contributor

elalish commented May 17, 2023

LGTM, thanks!

@mrdoob mrdoob added this to the r153 milestone May 18, 2023
@mrdoob mrdoob merged commit c0d63d7 into mrdoob:dev May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants