Skip to content

page.js: accepts multiline callargs #26030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2023
Merged

page.js: accepts multiline callargs #26030

merged 1 commit into from
May 10, 2023

Conversation

@ycw
Copy link
Contributor

@ycw ycw commented May 10, 2023

fixed #25921

tested https://regex101.com/r/bPfp7q/1 with real sample

three.js/docs/api/en/renderers/WebGLRenderer.html

Lines 567 to 570 in 44ab823

<h3>
[method:undefined setRenderTarget]( [param:WebGLRenderTarget renderTarget],
[param:Integer activeCubeFace], [param:Integer activeMipmapLevel] )
</h3>

@Mugen87 Mugen87 added this to the r153 milestone May 10, 2023
Mugen87
Mugen87 approved these changes May 10, 2023
View reviewed changes
Copy link
Collaborator

@Mugen87 Mugen87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This indeed fixes the issue! Awesome!

@Mugen87 Mugen87 merged commit 694797f into mrdoob:dev May 10, 2023
@ycw ycw deleted the patch-2 branch May 10, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r153

Development

Successfully merging this pull request may close these issues.

Docs: Broken formatting on some method signatures

2 participants

@ycw @Mugen87