HTMLMesh: Remove the +0.5 offset for image #25930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #25655 and PR #25916 that was merged with follow-up discussion in #25925
Description
Remove the +0.5 offset for image. That was ok with a button wrapping the image, button having a border of 2px, but not ok for a border of 1px, the image wasn't centered.
We need to keep the -0.5 offset so the image is centered in the button container that does a render with the -0.5 offset.
Note in #25925 it was mentioned a lesser quality of the image with -0.5 offset although I don't see it in VR.