KTX2Loader: Return LODs through DataTexture's mipmaps field. #25871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make parallel calls to createDataTexture for each level, then return them through the mipmaps array
Mugen87
changed the title
donmccurdy
reviewed
Apr 17, 2023
|
@donmccurdy The latest commit structures mipmaps as {data,width,height} POJOs and it renders properly. This sample uses NearestMipmapNearestFilter for minFilter to show the different levels (colors) being rendered, especially visible in the side view. |
donmccurdy
reviewed
Apr 24, 2023
Co-authored-by: Don McCurdy <[email protected]>
LeviPesin
reviewed
May 1, 2023
Co-authored-by: Levi Pesin <[email protected]>
donmccurdy
approved these changes
May 2, 2023
|
Thank you @emmanueljl! |
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the KTX2Loader is hardcoded to only process the first level. This backwards-compatible PR processes any additional levels and attaches them to the
mipmapsfield of the returned DataTexture.