WebGLShadowMap: Switching filters on switching shadow types fixed #25847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitalArt3DTobias
changed the title
Mugen87
approved these changes
Apr 16, 2023
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
reviewed
Apr 17, 2023
|
|
||
| } | ||
|
|
||
| _previousType = this.type; |
There was a problem hiding this comment.
When the shadow map type changes from/to VSM, all shadow maps (so all render targets) have to be recreated. Currently, this only happens for the first shadow map.
So I think this line has to be placed outside the for loop. I'll fix this on my side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #25835.
Avoids problems when switching to VSM shadows from other shadow types dynamically.