WebGPURenderer: Shadows Node-Based #25822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
LeviPesin
reviewed
Apr 13, 2023
LeviPesin
reviewed
Apr 13, 2023
|
Looking good! 🔥 |
5 tasks
This was referenced Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I made some modifications to the API so that we could do
RTTorComputeat the time of rendering, thus creating a render tree if necessary, more precisely at Node update time, the implementation of which is clearer in the use ofNode.updateBefore(), which is called in the process of theWebGPURenderer.renderObject()but before updating the matrices/uniforms. As the shadow is based on the architecture of the Nodes, it is not necessary to modify the core if you want to add a new filter or add a new type of shadow.https://raw.githack.com/sunag/three.js/dev-webgpu-shadows/examples/webgpu_shadowmap.html