-
-
Notifications
You must be signed in to change notification settings - Fork 36k
WebGLRenderer: Replace .outputEncoding with .outputColorSpace #25756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebGLRenderer: Replace .outputEncoding with .outputColorSpace #25756
Conversation
983405d to
cb6649a
Compare
21ed916 to
cf48f01
Compare
|
@Mugen87 from #23614 (comment) I understand we may want to break this into two PRs:
I'll split the PR tomorrow, unless you or @mrdoob would prefer otherwise. |
|
Yes, that would be great. |
cf48f01 to
9c8e46c
Compare
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
|
@Mugen87 - done! |
|
Merging this before even more conflicts occur. |
|
Feel free to improve the migration guide. I've just added a first draft: https://github.com/mrdoob/three.js/wiki/Migration-Guide |
|
Thanks @Mugen87! I'll make suggestions on the migration guide after the next few PRs (or before r152, if the PRs slip). |
|
Hello, I'm going to the renderer. OutputEncoding = THREE. SRGBEncoding replace the renderer. OutputColorSpace = THREE. SRGBColorSpace, the effect is completely different, THREE. The effect of SRGBColorSpace added and not added is almost the same, should this be handled? |
|
Hi @938640624, please use the forums (https://discourse.threejs.org/) or Stack Overflow and provide enough context (demo or code) for someone to fully and immediately reproduce the issue you're seeing. The renaming of the property has no side effects, but you may be seeing the results of other changes in recent three.js versions, as described here. In any case we prefer to help you work through these questions outside of GitHub issues. Thanks! |
Changes in this PR:
Remaining changes for r152, in next PRs:
Related issue: