Remove inline sRGB decode of video textures #25752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
approved these changes
Apr 2, 2023
|
Nice! I didn't realize https://crbug.com/1256340 got fixed! 🎉 |
38 tasks
This was referenced Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
Moves sRGB decode of video textures from the shader to hardware. Unlike with image textures, if the device supports neither WebGL 2 nor EXT_sRGB, we do not have a CPU decode fallback.
In addition to simplifying the renderer and a (probably modest) performance benefit, this makes life easier and more consistent for users handling video textures in custom shaders. See thread in the forums, R3F / Drei -> Image component with videoTexture. How do I fix brightness/tone mapping issue?, for context.