Cleanup: lint-addons and lint-examples

[hybridherbst]

Description

I'm using npm run lint-addons to check for linting errors. For a while, that has produced ~14 errors across files, and some for lint-examples.

This PR brings the errors down to 2 (which I don't know how to fix).

Remaining linter errors:

three\examples\jsm\loaders\LDrawLoader.js
767:12  error  Parsing error: Unexpected token {
(which is just `} catch {`)

three\examples\jsm\nodes\Nodes.js
34:10  error  Parsing error: Unexpected token as
(which is just `export * as NodeUtils from './core/NodeUtils.js';`)

[LeviPesin]

export * as NodeUtils from './core/NodeUtils.js

I think this is because the linter is configured to es2018?

[LeviPesin]

And I again suggest that we should add some lints to npm run lint... At least npm run lint-docs, npm run lint-addons, and npm run lint-examples.

[hybridherbst]

I think this is because the linter is configured to es2018?

Do you know whether this means the line has to be changed (to still support es2018) or the linter config has to be changed?

[Mugen87]

Do you know whether this means the line has to be changed (to still support es2018)

Correct.

[hybridherbst]

cc @sunag then I guess.

I can change } catch { to } catch ( _ ) { for the other line even when I don't quite understand why the linter doesn't like the former.

[sunag]

@hybridherbst It's ok for me.

[hybridherbst]

@sunag do you know what export * as NodeUtils from './core/NodeUtils.js'; needs to be changed to to make the linter happy? 🧐

[Mugen87]

Check out how this issue was solved in the core: #25470

[sunag]

I think an alternative could be?

// utils
import * as NodeUtils from './core/NodeUtils.js';
export { NodeUtils };

[Mugen87]

AFAIK, the usage of as in import statements is not ECMA2018 conform.

[Mugen87]

Merging this in the meanwhile. The open points can be fixed with another PR.