Skip to content

NodeEditor: Adds support for exporting Node Chaining, Materials and Objects3D (individually) #25553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 27, 2023
Merged

NodeEditor: Adds support for exporting Node Chaining, Materials and Objects3D (individually) #25553

merged 8 commits into from
Feb 27, 2023

Conversation

@sunag
Copy link
Collaborator

@sunag sunag commented Feb 22, 2023 •
edited
Loading

Description

This allows individually exporting Nodes, Materials and Objects3D to be used both in NodeMaterialLoader, NodeObjectLoader, NodeLoader.

image

@sunag sunag marked this pull request as ready for review February 22, 2023 19:02
@sunag sunag added this to the r150 milestone Feb 22, 2023
LeviPesin
LeviPesin reviewed Feb 23, 2023
View reviewed changes
@mrdoob mrdoob modified the milestones: r150, r151 Feb 23, 2023
@sunag sunag added the Nodes label Feb 24, 2023
@sunag
Copy link
Collaborator Author

sunag commented Feb 27, 2023

@LeviPesin I think we can think about use NodeUtils.getNodesKeys() in Node.getChildren() too.

@sunag sunag changed the title NodeEditor: Adds support for exporting Materials and Objects3D NodeEditor: Adds support for exporting Node Chaining, Materials and Objects3D (individually) Feb 27, 2023
@sunag sunag merged commit f9585c2 into mrdoob:dev Feb 27, 2023
@sunag sunag deleted the dev-editor-export-material branch February 27, 2023 20:56
@LeviPesin
Copy link
Contributor

I think we can think about use NodeUtils.getNodesKeys() in Node.getChildren() too.

Agreed! I can file a PR soon.

@LeviPesin LeviPesin mentioned this pull request Feb 28, 2023
Merged
@sunag sunag mentioned this pull request Mar 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@LeviPesin LeviPesin LeviPesin left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Nodes

Projects

None yet

Milestone

r151

Development

Successfully merging this pull request may close these issues.

3 participants

@sunag @LeviPesin @mrdoob