docs: update BufferAttribute docs to warn about changing usage #23960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
approved these changes
Apr 28, 2022
|
Should we also do this for setUsage? |
|
If you think it's more clear than feel free to update |
|
Done ✅ |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
…b#23960) * Update BufferAttribute docs to warn about changing `usage` * adds note to setUsage too * .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Mugen87 just to get the ball rolling 😄
We either put it with usage or at the top of the page, depends on wether it applies to other properties imo.
Preview 👉 https://raw.githack.com/gsimone/three.js/patch-1/docs/index.html?q=buffera#api/en/core/BufferAttribute