GLTFLoader: Honor Firefox version when checking for ImageBitmap. #23909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donmccurdy
reviewed
Apr 18, 2022
Collaborator
donmccurdy
left a comment
donmccurdy
left a comment
There was a problem hiding this comment.
Didn't we have code in ImageBitmapLoader to feature-detect support, at one point? Did that just not work because failure cases in Firefox were hard to detect?
Fine to keep UA-sniffing for now though, thanks!
takahirox
approved these changes
Apr 19, 2022
Collaborator
takahirox
left a comment
takahirox
left a comment
There was a problem hiding this comment.
Looking good, if it's ok for others to add a version detection code, too, thanks.
Owner
|
Thanks! |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
…oob#23909) * GLTFLoader: Honor Firefox version when checking for ImageBitmap. * GLTFLoader: Clarify ImageBitmap check. * GLTFLoader: Clean up. * GLTFLoader: More clean up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #23906.
Description
Only use
ImageBitmapLoaderwhen the version of Firefox is => 98.