Skip to content

OBJLoader: Convert vertex colors to Linear from sRGB #23340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2022
Merged

OBJLoader: Convert vertex colors to Linear from sRGB #23340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions examples/jsm/loaders/OBJLoader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ import {
MeshPhongMaterial,
Points,
PointsMaterial,
Vector3
Vector3,
Color
} from 'three';

// o object_name | g group_name
Expand All @@ -30,6 +31,8 @@ const _vC = new Vector3();
const _ab = new Vector3();
const _cb = new Vector3();

const _color = new Color();

function ParserState() {

const state = {
Expand Down Expand Up @@ -536,12 +539,13 @@ class OBJLoader extends Loader {
);
if ( data.length >= 7 ) {

state.colors.push(
_color.setRGB(
parseFloat( data[ 4 ] ),
parseFloat( data[ 5 ] ),
parseFloat( data[ 6 ] )
).convertSRGBToLinear();

);
state.colors.push( _color.r, _color.g, _color.b );

} else {

Expand Down