Skip to content

HTMLTexture: Don't overwrite dispatchEvent(). #23326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2022
Merged

HTMLTexture: Don't overwrite dispatchEvent(). #23326

merged 1 commit into from
Jan 25, 2022

Conversation

@Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jan 25, 2022 •
edited
Loading

Related #23319.

Description

The PR ensures that HTMLTexture does not overwrite Texture.dispatchEvent() which breaks Texture.dispose(). There is now a new method called dispatchDOMEvent() to dispatches events to the DOM.

@mrdoob
Copy link
Owner

mrdoob commented Jan 25, 2022

Ops...

@mrdoob mrdoob added this to the r137 milestone Jan 25, 2022
@mrdoob mrdoob merged commit 6bd0fbd into mrdoob:dev Jan 25, 2022
@mrdoob
Copy link
Owner

mrdoob commented Jan 25, 2022

Thanks!

@joshuaellis joshuaellis mentioned this pull request Jan 27, 2022
Closed
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r137

Development

Successfully merging this pull request may close these issues.

2 participants

@Mugen87 @mrdoob