Skip to content

Examples: Simplify Reflector, Refractor and Water render targets. #23206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 11, 2022
Merged

Examples: Simplify Reflector, Refractor and Water render targets. #23206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82bed62
Examples: Simplify Reflector, Refractor and Water render targets.
Mugen87 Jan 11, 2022
200bbb6
Examples: More clean up.
Mugen87 Jan 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 1 addition & 16 deletions examples/jsm/objects/Reflector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
import {
Color,
LinearFilter,
MathUtils,
Matrix4,
Mesh,
PerspectiveCamera,
Plane,
RGBFormat,
ShaderMaterial,
UniformsUtils,
Vector3,
Expand Down Expand Up @@ -47,19 +44,7 @@ class Reflector extends Mesh {
const textureMatrix = new Matrix4();
const virtualCamera = new PerspectiveCamera();

const parameters = {
minFilter: LinearFilter,
magFilter: LinearFilter,
format: RGBFormat
};

const renderTarget = new WebGLRenderTarget( textureWidth, textureHeight, parameters );

if ( ! MathUtils.isPowerOfTwo( textureWidth ) || ! MathUtils.isPowerOfTwo( textureHeight ) ) {

renderTarget.texture.generateMipmaps = false;

}
const renderTarget = new WebGLRenderTarget( textureWidth, textureHeight );

const material = new ShaderMaterial( {
uniforms: UniformsUtils.clone( shader.uniforms ),
Expand Down
17 changes: 1 addition & 16 deletions examples/jsm/objects/Refractor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
import {
Color,
LinearFilter,
MathUtils,
Matrix4,
Mesh,
PerspectiveCamera,
Plane,
Quaternion,
RGBFormat,
ShaderMaterial,
UniformsUtils,
Vector3,
Expand Down Expand Up @@ -44,19 +41,7 @@ class Refractor extends Mesh {

// render target

const parameters = {
minFilter: LinearFilter,
magFilter: LinearFilter,
format: RGBFormat
};

const renderTarget = new WebGLRenderTarget( textureWidth, textureHeight, parameters );

if ( ! MathUtils.isPowerOfTwo( textureWidth ) || ! MathUtils.isPowerOfTwo( textureHeight ) ) {

renderTarget.texture.generateMipmaps = false;

}
const renderTarget = new WebGLRenderTarget( textureWidth, textureHeight );

// material

Expand Down
17 changes: 1 addition & 16 deletions examples/jsm/objects/Water.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
import {
Color,
FrontSide,
LinearFilter,
MathUtils,
Matrix4,
Mesh,
PerspectiveCamera,
Plane,
RGBFormat,
ShaderMaterial,
UniformsLib,
UniformsUtils,
Expand Down Expand Up @@ -64,19 +61,7 @@ class Water extends Mesh {

const mirrorCamera = new PerspectiveCamera();

const parameters = {
minFilter: LinearFilter,
magFilter: LinearFilter,
format: RGBFormat
};

const renderTarget = new WebGLRenderTarget( textureWidth, textureHeight, parameters );

if ( ! MathUtils.isPowerOfTwo( textureWidth ) || ! MathUtils.isPowerOfTwo( textureHeight ) ) {

renderTarget.texture.generateMipmaps = false;

}
const renderTarget = new WebGLRenderTarget( textureWidth, textureHeight );

const mirrorShader = {

Expand Down