Skip to content

Fix typo in webgpu/constants.js #22795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2021
Merged

Fix typo in webgpu/constants.js #22795

merged 1 commit into from
Nov 7, 2021

Conversation

@takahirox
Copy link
Collaborator

@takahirox takahirox commented Nov 7, 2021 •
edited
Loading

Description

This PR fixes a typo in examples/jsm/renderers/webgpu/constants.js.

BRGA8Unorm: 'bgra8unorm',
BRGA8UnormSRGB: 'bgra8unorm-srgb',

The values are bgra* but the keys are BRGA*. I think the keys should be BGRA* unless they are intentional.

@mrdoob mrdoob added this to the r135 milestone Nov 7, 2021
@mrdoob mrdoob merged commit e683d19 into mrdoob:dev Nov 7, 2021
@mrdoob
Copy link
Owner

mrdoob commented Nov 7, 2021

Thanks!

@takahirox takahirox deleted the FixTypo branch November 7, 2021 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r135

Development

Successfully merging this pull request may close these issues.

2 participants

@takahirox @mrdoob