Shaders: Added new shader chunks for tangent support #22269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
approved these changes
Aug 4, 2021
|
Seems this PR breaks some node examples. |
|
/ping @sunag I am trying to make these PRs as concise and clear as possible so it is easy for you to see how it impacts Node. I am grateful for your help and/or feedback. |
|
I updated Node and the examples impacted by this PR. |
|
LGTM! |
|
For me it's great too. I was going to check it out now to fix... thanks! |
|
Thanks! |
0b5vr
added a commit
to pixiv/three-vrm
that referenced
this pull request
Oct 21, 2021
MasatoMakino
added a commit
to MasatoMakino/threejs-shader-materials
that referenced
this pull request
Jun 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds three new shader chunks to consolidate some frequently-used code patterns.
These shader chunks are required for universal tangent support.
The new shader chunks have been applied to
MeshPhongMaterialandMeshToonMaterialas a start.