DragControls: added onPointerDown parameters #22084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Yes, it is implicitly defined. But it is of course more readable when |
Mugen87
approved these changes
Jul 3, 2021
Owner
|
Thanks! |
ThorstenBux
added a commit
to ThorstenBux/three.js
that referenced
this pull request
Jul 6, 2021
…l-placement-usdz * commit 'd0340e3a147e290fa86d14bc3ed97d8e1c20602e': (79 commits) r130 (bis) Revert "Update revision (mrdoob#22087)" (mrdoob#22090) Update WebXR Layers example to compare quality. (mrdoob#22083) Update revision (mrdoob#22087) Updated examples builds Updated builds USDZExporter: Added map transparency support (mrdoob#22086) DragControls: added onPointerDown parameters (mrdoob#22084) Examples: Clean up. FBXLoader: Matrix4 code clean up. USDZExporter: Log a warning when matrixWorld has a negative scale. Docs: Improved AnimationMixer page. (mrdoob#22076) WebGLTextures: Fix mips gen for 3D render targets. (mrdoob#22072) Fix regression in WebXR (mrdoob#22074) Revert "TransformControls: Clean up." r130 Examples: Clean up Editor: Cache network responses in sw.js. Updated builds Updated examples builds ... # Conflicts: # examples/jsm/exporters/USDZExporter.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: null
Description
emm....
Even if you don’t add this parameter, it can still be executed normally.