Skip to content

Conversation

@makc
Copy link
Contributor

@makc makc commented Jun 5, 2021

the ridiculous :Float misake has been pointed out like half a year ago, and yet nobody is fixing it, so...

@mrdoob mrdoob added this to the r130 milestone Jun 10, 2021
@mrdoob
Copy link
Owner

mrdoob commented Jun 10, 2021

For consistency... Would it be okay if I change any to Any?

@Mugen87
Copy link
Collaborator

Mugen87 commented Jun 10, 2021

Make sense! All other type definitions start with a captial.

@mrdoob mrdoob merged commit ee537cc into mrdoob:dev Jun 10, 2021
@mrdoob
Copy link
Owner

mrdoob commented Jun 10, 2021

Thanks!

@mrdoob mrdoob changed the title fix getObjectByProperty docs Docs: Fix Object3D.getObjectByProperty Jun 10, 2021
@makc
Copy link
Contributor Author

makc commented Jun 10, 2021

@mrdoob I kind of went with typescript any subconsciously. could have just used a * or removed a type entirely

@makc makc deleted the patch-2 branch June 10, 2021 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants