Skip to content

examples: fix dark theme on empty location hash #21932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2021
Merged

examples: fix dark theme on empty location hash #21932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions examples/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ <h1><a href="https://threejs.org">three.js</a></h1>

selectFile( file );
viewer.src = validRedirects.get( file );
viewer.style.display = 'unset';

}

Expand Down Expand Up @@ -221,6 +222,7 @@ <h1><a href="https://threejs.org">three.js</a></h1>

window.location.hash = file;
viewer.focus();
viewer.style.display = 'unset';

panel.classList.remove( 'open' );

Expand Down
1 change: 1 addition & 0 deletions files/main.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,6 +383,7 @@ iframe {
width: 100%;
height: 100%;
overflow: auto;
display: none;
Copy link
Owner

@mrdoob mrdoob Jun 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh... This made all the projects in https://threejs.org/ disappear 😅

Copy link
Owner

@mrdoob mrdoob Jun 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reverted this line for now: 4f4c845

Would display: unset; work?

Copy link
Contributor Author

@felixmariotto felixmariotto Jun 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrdoob I can't find the html file of the home page, it's not in the repo ?

We could replace this line with the following, since #viewer in the homepage is a div :

iframe#viewer {
	display: none;
}

Copy link
Owner

@mrdoob mrdoob Jun 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrdoob I can't find the html file of the home page, it's not in the repo ?

It's in the gh-pages branch.

We could replace this line with the following, since #viewer in the homepage is a div :

Sounds good!

}

#viewer {
Expand Down