Skip to content

WebGLRenderer: Remove deprecated parameters check for render() #21777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2021
Merged

WebGLRenderer: Remove deprecated parameters check for render() #21777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 2 additions & 24 deletions src/renderers/WebGLRenderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -976,22 +976,6 @@ function WebGLRenderer( parameters ) {

this.render = function ( scene, camera ) {

let renderTarget, forceClear;

if ( arguments[ 2 ] !== undefined ) {

console.warn( 'THREE.WebGLRenderer.render(): the renderTarget argument has been removed. Use .setRenderTarget() instead.' );
renderTarget = arguments[ 2 ];

}

if ( arguments[ 3 ] !== undefined ) {

console.warn( 'THREE.WebGLRenderer.render(): the forceClear argument has been removed. Use .clear() instead.' );
forceClear = arguments[ 3 ];

}

if ( camera !== undefined && camera.isCamera !== true ) {

console.error( 'THREE.WebGLRenderer.render: camera is not an instance of THREE.Camera.' );
Expand All @@ -1016,7 +1000,7 @@ function WebGLRenderer( parameters ) {
}

//
if ( scene.isScene === true ) scene.onBeforeRender( _this, scene, camera, renderTarget || _currentRenderTarget );
if ( scene.isScene === true ) scene.onBeforeRender( _this, scene, camera, _currentRenderTarget );

currentRenderState = renderStates.get( scene, renderStateStack.length );
currentRenderState.init();
Expand Down Expand Up @@ -1061,15 +1045,9 @@ function WebGLRenderer( parameters ) {

if ( this.info.autoReset === true ) this.info.reset();

if ( renderTarget !== undefined ) {

this.setRenderTarget( renderTarget );

}

//

background.render( currentRenderList, scene, camera, forceClear );
background.render( currentRenderList, scene );

// render scene

Expand Down
3 changes: 2 additions & 1 deletion src/renderers/webgl/WebGLBackground.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,9 @@ function WebGLBackground( renderer, cubemaps, state, objects, premultipliedAlpha
let currentBackgroundVersion = 0;
let currentTonemapping = null;

function render( renderList, scene, camera, forceClear ) {
function render( renderList, scene ) {

let forceClear = false;
let background = scene.isScene === true ? scene.background : null;

if ( background && background.isTexture ) {
Expand Down