Skip to content

Examples: Convert controls to ES6 Part I. #21629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 10, 2021
Merged

Examples: Convert controls to ES6 Part I. #21629

merged 2 commits into from
Apr 10, 2021

Conversation

@Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Apr 10, 2021

Related issue: -

Description

Converts most controls to ES6.

@Mugen87 Mugen87 merged commit 495d3a0 into mrdoob:dev Apr 10, 2021
@Mugen87 Mugen87 added this to the r128 milestone Apr 10, 2021
@Mugen87
Copy link
Collaborator Author

Mugen87 commented Apr 10, 2021

@arodic I've already converted TransformControlsPlane and TransformControlsGizmo but I won't touch TransformControls since I'm not 100% sure about its internals. Would be great if you could move TransformControls to use classes so stuff like Object3D.call( this ); and Object3D.prototype.updateMatrixWorld.call( this );disappears.

@mrdoob
Copy link
Owner

mrdoob commented Apr 10, 2021

Thanks!

@Mugen87 Mugen87 mentioned this pull request Apr 13, 2021
Closed
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r128

Development

Successfully merging this pull request may close these issues.

2 participants

@Mugen87 @mrdoob