Skip to content

GridHelper: Removed colorCenterLine #21431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

GridHelper: Removed colorCenterLine #21431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions docs/api/en/helpers/GridHelper.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,11 @@ <h2>Examples</h2>

<h2>Constructor</h2>

<h3>[name]( [param:number size], [param:Number divisions], [param:Color colorCenterLine], [param:Color colorGrid] )</h3>
<h3>[name]( [param:number size], [param:Number divisions], [param:Color color] )</h3>
<p>
size -- The size of the grid. Default is 10. <br />
divisions -- The number of divisions across the grid. Default is 10. <br />
colorCenterLine -- The color of the centerline. This can be a [page:Color], a hexadecimal value and an CSS-Color name. Default is 0x444444 <br />
colorGrid -- The color of the lines of the grid. This can be a [page:Color], a hexadecimal value and an CSS-Color name. Default is 0x888888
color -- The color of the lines of the grid. This can be a [page:Color], a hexadecimal value and an CSS-Color name. Default is 0x888888
</p>
<p>
Creates a new [name] of size 'size' and divided into 'divisions' segments per side. Colors are optional.
Expand Down
21 changes: 4 additions & 17 deletions src/helpers/GridHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,40 +2,27 @@ import { LineSegments } from '../objects/LineSegments.js';
import { LineBasicMaterial } from '../materials/LineBasicMaterial.js';
import { Float32BufferAttribute } from '../core/BufferAttribute.js';
import { BufferGeometry } from '../core/BufferGeometry.js';
import { Color } from '../math/Color.js';

class GridHelper extends LineSegments {

constructor( size = 10, divisions = 10, color1 = 0x444444, color2 = 0x888888 ) {
constructor( size = 10, divisions = 10, color = 0x444444 ) {

color1 = new Color( color1 );
color2 = new Color( color2 );

const center = divisions / 2;
const step = size / divisions;
const halfSize = size / 2;

const vertices = [], colors = [];
const vertices = [];

for ( let i = 0, j = 0, k = - halfSize; i <= divisions; i ++, k += step ) {
for ( let i = 0, k = - halfSize; i <= divisions; i ++, k += step ) {

vertices.push( - halfSize, 0, k, halfSize, 0, k );
vertices.push( k, 0, - halfSize, k, 0, halfSize );

const color = i === center ? color1 : color2;

color.toArray( colors, j ); j += 3;
color.toArray( colors, j ); j += 3;
color.toArray( colors, j ); j += 3;
color.toArray( colors, j ); j += 3;

}

const geometry = new BufferGeometry();
geometry.setAttribute( 'position', new Float32BufferAttribute( vertices, 3 ) );
geometry.setAttribute( 'color', new Float32BufferAttribute( colors, 3 ) );

const material = new LineBasicMaterial( { vertexColors: true, toneMapped: false } );
const material = new LineBasicMaterial( { color: color, toneMapped: false } );

super( geometry, material );

Expand Down