Skip to content

Conversation

@gkjohnson
Copy link
Collaborator

@gkjohnson gkjohnson commented Mar 2, 2021

Related issue: #21383

Description

Adjust the ATC shader so it the wireframe lines are a consistent thickness. Thanks for adding in the alpha to coverage option!

image

cc @Mugen87 @WestLangley

@Mugen87
Copy link
Collaborator

Mugen87 commented Mar 2, 2021

Thanks for doing this! The wireframes are now easier to compare. The crisp lines of the AtC wireframe are fantastic!

@mrdoob mrdoob added this to the r127 milestone Mar 2, 2021
@mrdoob mrdoob merged commit 8a59d96 into mrdoob:dev Mar 2, 2021
@mrdoob
Copy link
Owner

mrdoob commented Mar 2, 2021

Thanks!

@gkjohnson gkjohnson deleted the wireframe-thickness branch March 2, 2021 16:14
@gkjohnson
Copy link
Collaborator Author

The crisp lines of the AtC wireframe are fantastic!

It looks so good!

@WestLangley
Copy link
Collaborator

Should be

uniforms: { 'thickness': { value: API.thickness } },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants