Skip to content

Conversation

@Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Feb 26, 2021

Related issue: Fixed #17761.

Description

The reason for this change is explained in #17710.

scene.onAfterRender must be called after multiview or multisampled rendertargets do their blitFramebuffer for post proc to have valid data in the renderTarget.

The original PR was hard to test because it contained too many changes at once. #18626 implemented one part of it. This PR is about onAfterRender(). The changes related to WebGLMutliview are not relevant anymore. And the issue in WebGLTextures should be solved via #18904.

@mrdoob mrdoob added this to the r127 milestone Feb 26, 2021
@mrdoob mrdoob merged commit 33e0a86 into mrdoob:dev Feb 26, 2021
@mrdoob
Copy link
Owner

mrdoob commented Feb 26, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scene.onAfterRender behavior inconsistent between WebGL context versions

2 participants