BufferAttribute .name, .usage, .updateRange serialization #21279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takahirox
commented
Feb 15, 2021
|
By the way, I found that https://github.com/mrdoob/three.js/blob/r125/src/core/BufferGeometry.js#L934 Do you folks know what's this design for? |
|
No idea, but that is confusing. |
|
It seems the line was missed to be moved into I would suggest moving the line (meaning, deleting the line of |
…updateRange serialization
…ute can be deserialized
…) because it should be done in BufferAttribute.toJSON()
takahirox
force-pushed
the
ImproveBufferAttributeToJSON
branch
from
8e1a3ac to
54d246f
Compare
Mugen87
approved these changes
Mar 15, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: #21225
Description
This PR adds missing
BufferAttribute.name,.usage, and.updateRangeserialization and deserialization toBufferAttribute.toJSON()andBufferGeometryLoader.parse()and adds unit tests to check them.